Star rating not usable for Pages?

Discuss PivotX 2.0.x extensions here, and view extensions that are available for download.

Star rating not usable for Pages?

Postby Harm10 » Sun Nov 08, 2009 8:49 pm

I tried using Star rating on my testpages and testentries. On the entries it's all seems to be working fine (except for the known display inline problem in the css) and I can vote normally. The rating is shown correctly.
For the pages I have a problem. I can vote normally, click on the star I want but no registering of this vote seems to happen because the rating remains at zero and when I revisit the page my vote is not visible anymore.
I looked at the sources that are generated by PivotX and all components belonging to the extension seem to be there.
So why isn't it working? Am I missing something?
Quality is in the detail of things............

Want to change or update your PivotX site? Mail or PM me!
I can also convert your site to a Wordpress site!
Harm10
Developer
 
Posts: 2011
Joined: Wed Jun 17, 2009 9:37 am
Location: Somewhere in The Netherlands (aka Holland)

Re: Star rating not usable for Pages?

Postby hansfn » Sun Nov 08, 2009 10:59 pm

Because it's written just for entries - which is obvious if you look at extensions/starrating/starrating_submit.php.

PS! I agree 110% that it should have been documented that it only works for entries.
hansfn
Developer
 
Posts: 3282
Joined: Sun Nov 25, 2007 7:48 pm
Location: Molde, Norway

Re: Star rating not usable for Pages?

Postby Harm10 » Mon Nov 09, 2009 6:27 am

OK understandable. Is it easy to change so it also works for pages?
Quality is in the detail of things............

Want to change or update your PivotX site? Mail or PM me!
I can also convert your site to a Wordpress site!
Harm10
Developer
 
Posts: 2011
Joined: Wed Jun 17, 2009 9:37 am
Location: Somewhere in The Netherlands (aka Holland)

Re: Star rating not usable for Pages?

Postby hansfn » Mon Nov 09, 2009 7:19 am

I just glanced at the code, but it looks like it's trivial to implement support for pages.
hansfn
Developer
 
Posts: 3282
Joined: Sun Nov 25, 2007 7:48 pm
Location: Molde, Norway

Re: Star rating not usable for Pages?

Postby Harm10 » Mon Nov 09, 2009 11:25 am

hansfn wrote:I just glanced at the code, but it looks like it's trivial to implement support for pages.

I like a challenge.......... I am going to have a look!
Quality is in the detail of things............

Want to change or update your PivotX site? Mail or PM me!
I can also convert your site to a Wordpress site!
Harm10
Developer
 
Posts: 2011
Joined: Wed Jun 17, 2009 9:37 am
Location: Somewhere in The Netherlands (aka Holland)

Re: Star rating not usable for Pages?

Postby Harm10 » Fri Nov 13, 2009 8:17 pm

I sent the changed files to Hans for review. In due time they'll end up in a revision (if the change is OK ofcourse ;) ).
Quality is in the detail of things............

Want to change or update your PivotX site? Mail or PM me!
I can also convert your site to a Wordpress site!
Harm10
Developer
 
Posts: 2011
Joined: Wed Jun 17, 2009 9:37 am
Location: Somewhere in The Netherlands (aka Holland)

Re: Star rating not usable for Pages?

Postby hansfn » Fri Nov 13, 2009 9:41 pm

A slightly modified version of the code Harm sent me is commited as revision 2207. It seems to work nicely on pages too - thx, Harm!
hansfn
Developer
 
Posts: 3282
Joined: Sun Nov 25, 2007 7:48 pm
Location: Molde, Norway

Re: Star rating not usable for Pages?

Postby Harm10 » Sat Nov 14, 2009 10:58 pm

Implemented the official revision and it works fine! Thanks Hans, for implementing it!
Quality is in the detail of things............

Want to change or update your PivotX site? Mail or PM me!
I can also convert your site to a Wordpress site!
Harm10
Developer
 
Posts: 2011
Joined: Wed Jun 17, 2009 9:37 am
Location: Somewhere in The Netherlands (aka Holland)


Return to 2.x Extensions

Who is online

Users browsing this forum: No registered users and 1 guest

cron