Fancybox in Gallery on Pages

This is the place to discuss bugs that have been found in the most recent version of PivotX. Posting bugs will ensure that the Development Team is aware of them and that they will be addressed when resources are available.

Re: Fancybox in Gallery on Pages

Postby Harm10 » Wed Sep 23, 2009 6:44 pm

hansfn wrote:Harm10, does your extensions/gallery/hook_gallery.php have the following lines?

If so, the "<!-- [[popup]] -->" trick shouldn't be necessary ...
Sorry it took a while for me to answer. My computer had a major failure and had to be repaired....... :(
But now it's working fine again.
The lines you specified are there in the hook_gallery.php. Do you want me to test something?
Quality is in the detail of things............

Want to change or update your PivotX site? Mail or PM me!
I can also convert your site to a Wordpress site!
Harm10
Developer
 
Posts: 2011
Joined: Wed Jun 17, 2009 9:37 am
Location: Somewhere in The Netherlands (aka Holland)

Re: Fancybox in Gallery on Pages

Postby hansfn » Thu Sep 24, 2009 8:12 pm

Could you please try to remove "<!-- [[popup]] -->" from the template. The gallery should work on pages anyway. If it doesn't work, please post an URL (or PM me an URL so I can see for myself).
hansfn
Developer
 
Posts: 3282
Joined: Sun Nov 25, 2007 7:48 pm
Location: Molde, Norway

Re: Fancybox in Gallery on Pages

Postby Harm10 » Thu Sep 24, 2009 8:59 pm

PM sent!
Quality is in the detail of things............

Want to change or update your PivotX site? Mail or PM me!
I can also convert your site to a Wordpress site!
Harm10
Developer
 
Posts: 2011
Joined: Wed Jun 17, 2009 9:37 am
Location: Somewhere in The Netherlands (aka Holland)

Re: Fancybox in Gallery on Pages

Postby hansfn » Thu Sep 24, 2009 11:51 pm

Thx for the PM. I was able to reproduce it on my own site - I just hadn't understood the problem properly.

I have fixed this issue by updating both the fancybox and gallery extension (in revision 2150). I'll let the updated comment/documentation inside extensions/gallery/hook_gallery.php do the talking:

Code: Select all
/**
 * Example for use in templates:
 *
 *  <div class="gallery">
 *  [[gallery popup="thickbox"]]
 *    <a href='%imageurl%%filename%' class="thickbox" title="%nicefilename%" rel="gallery-%uid%" >
 *    <img src="%pivotxurl%includes/timthumb.php?src=%filename%&amp;w=106&amp;h=80&amp;zc=1" alt="%filename%" />
 *    </a>
 *  [[/gallery]]
 *  </div>
 *
 * If you have enabled the fancybox extension and want to use it instead,
 * replace the two "thickbox" strings with "fancybox" in the example above.
 */

No need for ugly tricks anymore ...
hansfn
Developer
 
Posts: 3282
Joined: Sun Nov 25, 2007 7:48 pm
Location: Molde, Norway

Re: Fancybox in Gallery on Pages

Postby Harm10 » Sat Sep 26, 2009 4:35 pm

I implemented the revision and it works fine!

(Slightly edited by hansfn.)
Quality is in the detail of things............

Want to change or update your PivotX site? Mail or PM me!
I can also convert your site to a Wordpress site!
Harm10
Developer
 
Posts: 2011
Joined: Wed Jun 17, 2009 9:37 am
Location: Somewhere in The Netherlands (aka Holland)

Previous

Return to 2.x Bugs

Who is online

Users browsing this forum: No registered users and 1 guest

cron