(small) bug in superfish menu 1

This is the place to discuss bugs that have been found in the most recent version of PivotX. Posting bugs will ensure that the Development Team is aware of them and that they will be addressed when resources are available.

(small) bug in superfish menu 1

Postby artman » Fri Feb 01, 2013 8:37 pm

In superfish menu I notice in some browsers in the bottom a error note.
The error is from a js script.
I use the magazine template where superfish is installed.
Find in the header tpl;
Code: Select all
 <script type="text/javascript" src="[[template_dir]]js/hoverIntent.js"></script>
                     <script type="text/javascript" src="[[template_dir]]js/superfish.js"></script>
             <script type="text/javascript" src="[[template_dir]]quickpager.jquery.js"></script>
<script type="text/javascript">
   
      $(document).ready(function(){
         $("ul.sf-menu").superfish();
      });
   
   </script>


The error comr from;
Code: Select all
<script type="text/javascript">
   
      $(document).ready(function(){
         $("ul.sf-menu").superfish();
      });
   
   </script>


If you remove that part of code the menu is still working and give no errors anymore.


Marten
artman
 
Posts: 12
Joined: Tue Jan 15, 2013 4:51 pm

Re: (small) bug in superfish menu 1

Postby Harm10 » Fri Feb 01, 2013 11:31 pm

This is probably due to the fact that currently the $ characters should be replaced by jQuery.
The code should read
Code: Select all
<script type="text/javascript">
   
      jQuery(document).ready(function(){
         jQuery("ul.sf-menu").superfish();
      });
   
   </script>
Could you please verify?
Quality is in the detail of things............

Want to change or update your PivotX site? Mail or PM me!
I can also convert your site to a Wordpress site!
Harm10
Developer
 
Posts: 2010
Joined: Wed Jun 17, 2009 9:37 am
Location: Somewhere in The Netherlands (aka Holland)

Re: (small) bug in superfish menu 1

Postby artman » Sat Feb 02, 2013 4:50 pm

Have ad the code to the template there is no error more.
Menu work good.

Although in the admin section is also a browser js error ;
Can put it here of start a new topic.

Marten
artman
 
Posts: 12
Joined: Tue Jan 15, 2013 4:51 pm

Re: (small) bug in superfish menu 1

Postby Harm10 » Sat Feb 02, 2013 5:05 pm

Thanks for reporting. I will change the Magazine theme so new users won't get the same error.

New problem = New post ;)
Quality is in the detail of things............

Want to change or update your PivotX site? Mail or PM me!
I can also convert your site to a Wordpress site!
Harm10
Developer
 
Posts: 2010
Joined: Wed Jun 17, 2009 9:37 am
Location: Somewhere in The Netherlands (aka Holland)

Re: (small) bug in superfish menu 1

Postby tobeymurphy » Wed Aug 20, 2014 8:30 pm

Why do you use a plugin for menu, when it can be done in few lines of code by yourself? Here are some examples: jQuery for beginners - JavaScript menu all of them take few lines of code and can be used in different places, top, left, right menu.
tobeymurphy
 
Posts: 1
Joined: Wed Aug 20, 2014 4:51 pm

Re: (small) bug in superfish menu 1

Postby Harm10 » Wed Aug 20, 2014 9:39 pm

tobeymurphy wrote:Why do you use a plugin for menu, when it can be done in few lines of code by yourself?

Sure, it is not that hard. But you need to be a coder of some kind. If you just want to use PivotX and one of its themes you do not know how to do that (and probably do not want to know).
Quality is in the detail of things............

Want to change or update your PivotX site? Mail or PM me!
I can also convert your site to a Wordpress site!
Harm10
Developer
 
Posts: 2010
Joined: Wed Jun 17, 2009 9:37 am
Location: Somewhere in The Netherlands (aka Holland)


Return to 2.x Bugs

Who is online

Users browsing this forum: Yahoo [Bot] and 4 guests

cron